RodZill4/material-maker

Repository cleanup suggestions

Opened this issue · 1 comments

Jowan-Spooner commented

This might be a bit of a bold issue to make, but these are some things that I just wanted to discuss, while trying to find my way around the repo. I think removing unnecessary content is a significant improvement for anyone who wants to work with the source code!

  • Remove res://Scripts

    • Seems like it's not needed anymore, script has been broken for a while?
    • Otherwise improving the naming. Both "Scripts" and "fixup.gd" mean basically nothing

  • Remove or Fix res://demo

    • The two files in it have been broken due to missing dependencies.

  • Remove res://start.tscn & res://start.gd (seem to be dead leftovers)

  • Rename res://material_maker

    • Having a folder called material maker in the material maker repo tells me absolutely nothing about it's content. What makes this more "MaterialMaker" then the rest of the files? I think this folder contains all the UI of the material maker program, so maybe "Interface", "App" or "UI" would be better? However that still doesn't explain why the SplashScreen is in a separate folder...
    • This one is probably the most work out of all of these, because a lot of references might break, but it's certainly doable, and worth it imo.

Please let me know if there is something I missed/misunderstood.

I know organization/cleanup is not a fun task, but I think it's really important for future developement. Btw, I can do it, even in separate small PR's if there is interest.

RodZill4 commented

Scripts is a directory for utilities that don't belong to MM. the fixup script was used to update predefine nodes (still have to port it to Godot 4).
The demo is not ported (yet). I'll probably remove it.
The old start scene still has stuff that's not yet in the new one. I'll delete it when that part is done.
The material_maker folder contains the UI. I still have to move stuff around, but yeah, it could be named "ui".

  • 👍1