Rolisteam/DiceParser

Small Qt API issue (prevent compiling on Debian Buster)

Closed this issue · 1 comments

ldng commented

I had to apply the following patch to compile on Buster :

diff --git a/node/sortresult.cpp b/node/sortresult.cpp
index 81086f2..89043fa 100644
--- a/node/sortresult.cpp
+++ b/node/sortresult.cpp
@@ -101,7 +101,7 @@ void SortResultNode::run(ExecutionNode* node)
         {
             for(int i= 0; i < diceList2.size() / 2; ++i)
             {
-                diceList2.swapItemsAt(i, diceList2.size() - (1 + i));
+                diceList2.swap(i, diceList2.size() - (1 + i));
             }
         }
         m_diceResult->setResultList(diceList2);

Apparently swapItemsAt is for Qt 5.13 forward but Debian 10 is at 5.11 for now.
I don't know if it's really worth fixing, as you see fit guys :-)

There is a git branch to compile with 5.11 the master will keep that.