[DCC] Saves, Weapon Attacks, and other buttons missing modifiers

Question

[DCC] Saves, Weapon Attacks, and other buttons missing modifiers

DBendit opened this issue a year ago · 8 comments

I'm assuming this is the source of the problem: 8a5f241

Buttons for the various saves and weapon attacks are missing the total modifier value and the values are missing from the "Attributes & Abilities" tab. Clicking those buttons rolls the saves, but no modifiers are included (shows Rolling 1d20+ = (18)). It's as if setting those fields readonly removed them from various Roll20 sheet functionality.

DBendit commented a year ago

#12133

Answer 1 · 2023-09-06T00:32:19.000Z

Pinging @sturtus , since it's their commit :)

Answer 2 · 2023-09-06T00:39:49.000Z

Manually setting (WILL|REF|FORT)Check causes the buttons to populate as expected.

Answer 3 · 2023-09-06T00:46:09.000Z

I don't have a Pro account anymore so I can't really test. Insane that Roll20 makes us pay to contribute to their product.

Answer 4 · 2023-09-06T00:48:37.000Z

I'm in the same boat 🤣 The most I can recommend is rolling back the change, which will at least take it back to a known more-functional state.

Answer 5 · 2023-09-06T15:36:28.000Z

I had a friend with Plus. Was able to test/fix and submitted a new PR.

…

On Tue, Sep 5, 2023 at 8:48 PM Dave Bendit ***@***.***> wrote: I'm in the same boat 🤣 The most I can recommend is rolling back the change, which will at least take it back to a known more-functional state. — Reply to this email directly, view it on GitHub <#12132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPA37VUBSOEMNX7DVLS7G3XY7B7DANCNFSM6AAAAAA4MQVMYE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Answer 6 · 2023-09-07T00:00:30.000Z

This got merged in and looks good to me.

Answer 7 · 2023-09-07T03:31:33.000Z

Confirmed, looks like the issue's resolved. Thanks!