Roll20/roll20-character-sheets

[GURPS] 2.9.20 rollback and Roll20 issue with newly added field

MadCoder253 opened this issue · 0 comments

[GURPS] 2.9.20 was merged on Monday (10/30/2023) but sometime yesterday (10/31/2023) the sheet was reverted to [GURPS] 2.9.19. I haven't received any notifications as to why and there are still important updates that I will have to re-add with the next version. There's also nothing in the repo to indicate the sheet was rolled back.

I'm going to assume the rollback is related to an issue with a new field, since we had one person report that the character sheet navigation bar disappeared on them.

I added a brand new (NEVER used before) field named attr_sheet_type. The hidden field is set to character and there is also a set of radio buttons to select either character or chase and the radio button defaults to character. I helped the user fix their character sheet by asking them to modify the DOM directly. When he edited the DOM, the value for attr_sheet_type was set to Primary.

The GURPS sheet never used that field before, as far as I can tell, the default value is clearly set to character and yet for that person and maybe others, the value was set to Primary. I would like to know how this could happen and how to prevent this from happening again. Is attr_sheet_type some legacy field used by Roll20 and was somehow set for some character sheets? Did something else happen on Roll20 data side that for some reason set the wrong value to that field?

I'm thinking of just renaming the field name to attr_gurps_sheet_type but I want to make sure some background process doesn't set it to the wrong value for some reason.