Consider removing autoStart, or at least disabling it by default
RubenVerborgh opened this issue · 7 comments
Related to this. If we invoke transform on an iterator with autoStart set to false, should this new iterator inherit autoStart: false?
(This seems to be not the case at the moment)
As I mentioned in comunica/comunica#907 - it may be useful have this change made prior to the v2 release of Comunica. @rubensworks you noted that "making this change in AsyncIterator might not be trivial." - what kind of problems are you envisioning?
what kind of problems are you envisioning?
Not sure. I just remember spending a lot of time debugging things related to autoStart :-)
But if everything related to autoStart: false works properly now, then it should just be a matter of flipping the default value.
@RubenVerborgh might also have some thoughts about this.
I'm happy to have this change—is there still time? Can release as a v4.0.0-beta first.
It might be quite some precision work though in the tests etc.
Also wondering about time. I hope to enter beta testing for Comunica 2.x later this week.
If we release the beta of asynciterator today I can spend tommorow seeing trying to upgrade comunica - if it's too hard/time consuming then we can just leave it out?
If we release the beta of asynciterator today I can spend tommorow seeing trying to upgrade comunica - if it's too hard/time consuming then we can just leave it out?
Sounds good to me, if you think it's feasible to flip the default value of autoStart here in such a short time.