RunOnFlux/fluxnode-multitool

[FEATURE_REQUEST] Allow multitoolbox testing against custom RunOnFlux branches

Closed this issue · 1 comments

Is your feature request related to a problem? If so, please describe.

Currently, Multitoolbox is difficult to test, since all multitoolbox GitHub paths are hard-coded into the scripts themselves. It's difficult to test changes on a PR since all scripts point to master and not the branch of the PR itself.

Having a way to specify a specific branch for testing purposes would allow for testing those branches without having to commit new code to point to the desired RunOnFlux branch.

Describe the solution you'd like

Something like the following syntax appears to be valid bash syntax that might work for the multitoolbox, but has not been tested yet, just an idea getting on paper.

curl -s https://raw.githubusercontent.com/RunOnFlux/fluxnode-multitool/master/multitoolbox.sh | bash -i -- -testBranch some_test_branch_name

The default behavior would be to run against master, but can be overridden by an option defined at the beginning of multitoolbox like a -testBranch parameter or even assuming positional parameters for this use-case.

Referencing this article.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

Maybe

Closed by #23