Ruslan-B/FFmpeg.AutoGen

Latest commit inverts Path.Combine and GetNativeLibraryName calls

exelix11 opened this issue · 2 comments

  • **I'm submitting a ... **

    • bug report
    • feature request
    • support request or question => Please do not submit support request or questions here, see note at the top of this template.
  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    This was introduced in the latest commit:

    var nativeLibraryName = GetNativeLibraryName(Path.Combine(ffmpeg.RootPath, libraryName), version);
    ptr = LoadNativeLibrary(nativeLibraryName);

    On linux GetNativeLibraryName prepend lib to the full path but it should be added only to the library name

  • *If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem:
    N/A. Did not test, just noticed this while reading the code to debug a related issue before realizing i was on an older version from nuget, still worth reporting this.

  • What is the expected behavior?
    The previous implementation was correct

    var nativeLibraryName = GetNativeLibraryName(libraryName, version);
    var fullName = Path.Combine(path, nativeLibraryName);
    return LoadNativeLibrary(fullName);

Thanks, I'll fix it asap and release new set of packages.

Fixed in v5.1.2