Rename Sink::empty

Question

Rename Sink::empty

dvdsk opened this issue 10 months ago · 4 comments

dvdsk commented 10 months ago

It should probably be called is_empty. Clippy even flags on it.

Changing it would break a lot of code though...
Could deprecate it first?

Let me hear you thoughts, for now I am letting clippy now to ignore it.

Answer 1 · 2024-03-26T11:31:00.000Z

same is true for SpatialSink::empty

Answer 2 · 2024-06-11T20:09:04.000Z

Any improvements on this?

Answer 3 · 2024-06-11T20:32:30.000Z

not really, I am saving up some breaking changes for a big release. I rather not break ppls code multiple times. So it seems logical to save it up and provide a porting guide.

Answer 4 · 2024-06-11T20:33:10.000Z

though it might make sense to start collecting the changes on a new branch