RustCrypto/elliptic-curves

k256: missing check in `PrehashVerifier` impl for `schnorr::VerifyingKey`?

Closed this issue · 1 comments

fjarri commented

In BIP-340, the verification checks include:

  • Fail if is_infinite(R).
  • Fail if not has_even_y(R).
  • Fail if x(R) ≠ r.

In

elliptic-curves/k256/src/schnorr/verifying.rs

Line 61 in 5c829a4

fn verify_prehash(
we only do the second and the third check, but not the first. Is it intentional?

tarcieri commented

The first check does indeed appear to be missing