Ryosuke839/UnicodePad

F-Droid can't build anymore since `com.google.android.gms:play-services-ads(-lite)` are not open-source.

Closed this issue · 10 comments

lfourquaux commented

F-Droid can't build anymore since com.google.android.gms:play-services-ads(-lite) are not open-source.

Originally posted by @licaon-kter in #17 (comment)

The F-Droid version is increasingly outdated, it would be nice to have a fully open source, up to date version of UnicodePad.

TPS commented

@Ryosuke839 What's needed is a flavor to include only what's acceptable to build for F-droid.

@licaon-kter, @IzzySoft: Any pointers on how to do such would be much appreciated. 🙇🏾‍♂️

IzzySoft commented

I'm neither dev nor packager – so the only advice I can give is check with other apps which have done that (setting up separate flavors). In our *.yml files you can tell them by using gradle with a specific name, e.g.

gradle:
  - foss

foss and fdroid are quite common with those, so a egrep '^\s*- (fdroid|foss)' *.yml should help identifying them.

  • 🚀1
t-8ch commented

@Ryosuke839 Would you accept a pullrequest for such a build variant?

  • ❤️1
  • 🚀1
Ryosuke839 commented

@t-8ch Yes! I will definitely accept on this repo once I validate the behavior.

  • ❤️1
  • 🚀1
t-8ch commented

@Ryosuke839 Thanks!
@TPS Welp, I managed to mess up the PR, it should against the repo of @Ryosuke839 obviously :-)

TPS commented

@t-8ch You mentioned a problem in your PR, anyway. Probably better to fix there than PR here until it's resolved? Or not: #74

t-8ch commented

@TPS it's more of a validation issue. I expect it to actually work, but for some reason the Ads are not shown at all for me, even in the origin version.
If any changes are necessary I can do those in this PR easily.

  • 👍1
TPS commented

@IzzySoft Now that #74 is merged, is anything else needed to have F-Droid start publishing this again?

t-8ch commented

I think the timeline would be:

  • Wait for a new release of UnicodePad (I would just for the one containing Unicode 14)
  • Update the fdroid definitions to activate the "fdroid" flavor
linsui commented

2.9.1 will be published soon. See https://monitor.f-droid.org/builds/running. When the next release available please open an MR the update the build recipe.