Ryujinx/Ryujinx

Upscaling causes red tints to appear in some games

Theslees opened this issue · 7 comments

What's the issue you encountered?

Upscaling both A Hat in Time or Say No More causes a strange redness to appear on some of the geometry in both games. The more you upscale in SNM the more visible it becomes.

How can the issue be reproduced?

Booting any of the mentioned games, then upscale past native resolution

These games were tested under 2 enviroments, one is mine (AHiT) and the other is a different user's (SNM).

A Hat in Time Enviroment

Logs?

Ryujinx_1.1.171_2022-07-08_23-18-53.log

Environment?

  • Ryujinx version: 1.1.171

  • Game version: 1.0.4

  • System Specs:

    • OS: Arch linux 5.18.9-arch1-1 x86_64
    • CPU: AMD Ryzen 5 5600G
    • GPU: Vega 8 APU(integrated)
    • RAM: 32GB Dual channel SODIMM
  • Applied Mods : Yes, 60fps mod. Issue persists without mods though

Pictures:

image
Without upscale
image
With 2x upscale
image
Without upscale
image
With 2x upscale

Say No More Enviroment

Logs?

Ryujinx_1.1.166_2022-07-08_21-34-46.txt

Environment?

  • Ryujinx version: 1.1.166

  • Game version: 1.0

  • System Specs:

    • OS: Windows 10.0.22000 (X64)
    • CPU: AMD Ryzen 7 5800H
    • GPU: NVIDIA GeForce RTX 3060 Laptop
    • RAM: 16GB
  • Applied Mods : No

Pictures:

image
Without upscale
image
With 2x upscale
ryujinx_capture_2022-07-09_19-52-12
With 3x upscale

Additional Context

The red tint gets worst the more you upscale for SNM, but looks fine at 4x for some reason. For AHiT though, the game also has no red tints when it's upscaled to 3x too, but persists when going to 4x.

AHiT is a UE4 game and SNM is a Unity game, and the way the red tint appear is slightly different in both games (much more aggressive and noticible in SNM) We don't know if any other games have an issue like this so this is all we can provide for the bug report

There is another branch of this red tint with Say No! More where the tables in Chapter 3's meeting rooms also do not display propperly

ryujinx_capture_2022-07-09_20-18-40
[2x res]

ryujinx_capture_2022-07-09_20-18-55
[1X res]

This is likely related to colour LUTs that the games use for tonemapping, which can be 2d textures that are essentially a line of 3d slices. If they're scaled, it's possible for the edge of one slice to bleed into the other, so the solution would be to not scale them. I haven't yet looked into a good way to detect this.

The same issue occurs in World's End Club which is also a Unity game.

1x:
Ryujinx_1DTNvkaqEY

2x:
Ryujinx_IlhVa4eXaC

3x:
Ryujinx_jLjH6aLDCR

4x:
Ryujinx_whA9H6HDRY

And according to the game compatibility database the issue also occurs in Sherlock Holmes: The Devil's Daughter and Lost in Random

This issue is kind of a duplicate of #1488

@Niwu34 This issue is more specific than #1488 since we're talking about a pattern that occurs

This issue also occurs in Cruis'n Blast.

1x
ryujinx_capture_2022-07-12_14-16-45

2x
ryujinx_capture_2022-07-12_14-16-57

Fixed by #3464.