Add option to disable display in CLI

Question

Add option to disable display in CLI

Closed this issue a year ago · 6 comments

I think it would be nice to be able to disable displaying the figures when processing multiple files via CLI. Maybe adding a --display (or --no-display) flag as well as an option to save figures? If both showing and saving are off, then figure creation can be skipped completely.

Answer 1 · 2022-02-05T14:24:44.000Z

Yes indeed, I thought it was already the case. I will check that soon, thanks.

Answer 2 · 2022-02-14T13:19:14.000Z

Hi @vandalt, by default figures plot are skipped during clean, extract or calibrate step. You need to specify -p (--plot) to show the figures.

Answer 3 · 2022-02-14T13:46:20.000Z

You're right, sorry I missed that part. Do you think it would be worth also setting the display argument of amical functions to False as well when none of --plot or --save-to are used ?

Answer 4 · 2022-02-14T14:13:40.000Z

Do you propose to turn the display arguments to false by default everywhere?

Answer 5 · 2022-02-14T15:21:37.000Z

Not by default in AMICAL necessarily, but in the CLI calls. For example, in the block below, set display=False in the first clause because the figures are not used, and set to True only if --plot is used (in other steps, this would also require looking for --save-to to see if the figures are saved, if I understand correctly).

Answer 6 · 2022-07-26T19:31:43.000Z

FWIW this sounds good to me