SAP/cloud-sdk

Unresolved variable : clientId

alokchandna opened this issue · 8 comments

alokchandna commented

Issue Description

When I try to fetch a destination with Authentication OAuth2ClientCredentials from SAP BTP I get the error : {"fault":{"faultstring":"Unresolved variable : clientId","detail":{"errorcode":"steps.basicauthentication.UnresolvedVariable"}}}

Important information:

  • Your code : HttpDestination octDestination = DestinationAccessor.getDestination("ABC").asHttp();
  • Expected outcome : Get destination instance
  • Actual outcome : The destination service responded with an error: 500 Internal Server Error.
  • Steps attempted to resolve the issue : Delete and Create Destination again
  • In case of issues with any of our VDMs:
    • What happens when a request is performed directly via an HTTP client tool such as Postman? The token is received using postman. Although I did notice that earlier their used to be a scope variable in the token response but that variable is missing in the updated destination.

Impact / Priority

Affected development phase: Production

Impact: Blocked

Timeline: 1 week.

Error Message

Please paste your stack trace here within the backticks (replacing this comment)

dependency_tree.txt

Project Details

  • SAP Cloud SDK Version: 4.13.0
  • Link to GitHub repository:
  • Project type, for example:
    • SAP Cloud SDK Maven Archetype
  • Platform:
    • Cloud Foundry

Checklist

  • Checked out the documentation and Stack Overflow
  • Description provided with all relevant information
  • Attached dependency tree
  • Provided the SAP Cloud SDK version & link to relevant source code
Johannes-Schneider commented

Hi @alokchandna,

thanks for reaching out to us and please excuse our delayed response on your issue.
I'll take a look into this issue as soon as I can and come back to you if I do have any follow-up questions.

Best regards,
Johannes

Johannes-Schneider commented

Hi @alokchandna,

from the issue description, it seems like the issue is actually on the Destination service side.
To confirm / deny that suspicion, could you please try fetching the destination using a different REST client (such as Postman, for example)?
You can find documentation about how to consume the Destination service in the documentation.

Also: Did your application used to work? And, if so, what did you change in the meanwhile?
(I'm asking to make sure that there is no regression after, for example, updating the Cloud SDK dependency)

Best regards,
Johannes

alokchandna commented

Hi @Johannes-Schneider,
I did try to fetch the destination using postman and it works fine.
Also the destination used to work fine for one environment. But when I changed the environment(API endpoint, OAuth2 Creds), it started to give the error I mentioned earlier("Unresolved variable : clientId","detail":{"errorcode":"steps.basicauthentication.UnresolvedVariable").

Also, I did notice a small difference between the previous response from the destination token and the current one. Previously, the token response contained the 'scope' variable, but the new token response no longer includes it.

cschubertcs commented

Hi @alokchandna,

if I get it all completely it's as follows:

  • Initially you were using the destination succesfully with the SAP Cloud SDK
  • Then you changed the type of destination to OAuth2ClientCredentials
  • That removes the scope property in the response (verified using Postman)
  • The SDK now prints ther error you mentioned above

As the style of the error looks unknown to me I would like to ask you to activate logging for the HttpClient and provide the collected logs for the call to the destination service.

Based on that we can then better see where the error is coming from and how we can help you getting rid of the issue.

Greetings
Chris

alokchandna commented

Hi @cschubertcs,
I'd like to clarify a slight modification regarding your interpretation of the issue. Initially, the scope variable was included in the response, but now it is not. However, the destination type, OAuth2ClientCredentials, has remained unchanged.

Regards
Alok Chandna

cschubertcs commented

Hi @alokchandna,

ah, so that means the destination was already of type OAuth2ClientCredentials from the beginning?
Then I'm missing right now what has changed from your/client side that caused the changes in behavior.

In any way, could you create the logs and attach them, so that we can have a better understanding of the communication with the Destination Service? Keep in mind to retract any secret information.

Greetings
Chris

KavithaSiva commented

I am closing this issue due to inactivity, please feel free to re-open if you have further questions.

alokchandna commented

Hi @cschubertcs,
I refrained from responding earlier as I was actively working with SAP to resolve the issue privately, without publicly sharing the logs. I am pleased to inform you that SAP support was able to resolve the issue today. In order to assist others who may encounter a similar problem, I am sharing the resolution. The solution involved adding an additional property in the BTP destination configuration: tokenService.addClientCredentialsInBody set to false. Here is a revised response from SAP:

"The OAuth spec allows to get a token in 2 ways, by passing the client_id and client_secret as a request parameter or as a Basic Authorization header. Please try with changing the destination configuration to use Authorization header and add tokenService.addClientCredentialsInBody=false as it is true by default. Here you can find documentation: https://help.sap.com/docs/connectivity/sap-btp-connectivity-cf/oauth-client-credentials-authentication."

Regards
Alok Chandna