SAP/openui5-docs

Walkthrough's "Step 19: Reuse Dialogs" is now missing on https://openui5nightly.hana.ondemand.com

pubmikeb opened this issue · 3 comments

I've just paid attention that the Walkthrough's Step 19: Reuse Dialogs has been removed from the https://openui5nightly.hana.ondemand.com.

The Walkthrough on the stable version is a 38 steps manual, while the nightly version contains only 37 steps.

https://openui5nightly.hana.ondemand.com/topic/19453962b8074b7399372c65cbe05370 returns «Not found The requested resource was not found».

What's the reason of removing this step? Code reuse sounds quite critical for any framework.
It's interesting to get some details.

Hello @pubmikeb ,
Thank you for sharing this finding. I've created an internal incident 2170175244. The status of the issue will be updated here in GitHub.
Regards,

H4ze commented

Hi @pubmikeb,

the reason is, that this is just not necessary anymore.
We adjusted also "Step 16: Dialogs and Fragments" in order to use the new controller function loadFragment.
The old approach is not wrong but it's just not needed anymore.

Kind regards,
Johannes

Thodd commented

@pubmikeb I'll close this issue, @H4ze has described the reasoning behind the removal.