SAP/ui5-tooling

VersionInfoGenerator doesn't consider dependencies from `includeDependency`

petermuessig opened this issue · 7 comments

petermuessig commented

Expected Behavior

When an application defines the includeDependency in the ui5.yaml it should find the dependencies of the included dependency and not report an error.

Current Behavior

When a custom library is included via includeDependency into an application the versionInfoGenerator processor reports the following error:

info builder:processors:versionInfoGenerator Cannot find dependency 'sap.ui.core' defined in the manifest.json or .library file of project 'ui5.ecosystem.demo.tslib'. This might prevent some UI5 runtime performance optimizations from taking effect. Please double check your project's dependency configuration.

Steps to Reproduce the Issue

I will asap upload a change to the ui5-ecosystem-showcase which can be used to reproduce this issue:

  • git clone https://github.com/ui5-community/ui5-ecosystem-showcase.git
  • pnpm install
  • pnpm build:ts

This works as soon as you can find the package ui5-lib-ts in the repository.

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): unknown
  • Node.js Version: 16.19.0
  • npm Version: 8.19.3
  • OS/Platform: Mac
  • Browser (if relevant): n/a
  • Other information regarding your environment (optional): nothing

Log Output / Stack Trace

Issue in VSCode debugger:

image

info builder:processors:versionInfoGenerator Cannot find dependency 'sap.ui.core' defined in the manifest.json or .library file of project 'ui5.ecosystem.demo.tslib'. This might prevent some UI5 runtime performance optimizations from taking effect. Please double check your project's dependency configuration.
RandomByte commented

Hi Peter, thanks for reporting. Just let us know once ui5-lib-ts is available. We'll wait with the analysis until then 👍

github-actions commented

This issue has been automatically marked as stale because it has been open for 60 days with no activity. It will be closed in 10 days if no further activity occurs.

petermuessig commented

Oh, missed to comment here. The ui5-lib-ts is available...

matz3 commented

@petermuessig the project is using @ui5/cli v2.x which is deprecated.
Could you please upgrade to v3 and try again?

github-actions commented

This issue has been automatically marked as stale because it has been open for 60 days with no activity. It will be closed in 10 days if no further activity occurs.

flovogt commented

@petermuessig did you have another try with v3?