SAP/ui5-tooling

Build Execution Time in UI5 Tooling 3.0

shaiSAP opened this issue · 4 comments

After upgrading to UI Tooling 3.0 a build which took a few seconds now takes about 100 seconds.
(It might be a result of an invalid/incomplete configuration).
I'm attaching the verbose log of the build.
build_log.txt

Thank you for providing the build log.

For reference, linking your related comment in the SAP Community.

From the build log, I can see that you are building an application project with a custom task called ui5-task-nwabap-deployer. Opposing to UI5 Tooling v2, UI5 Tooling v3 needs to build all of your projects dependencies because the custom task might require access to some of them. This new behavior is also explained here.

From what I can see, the custom task ui5-task-nwabap-deployer doesn't actually require access to dependencies. I will therefore go ahead and recommend the author of that task to implement the recommended callback to signal this to UI5 Tooling as outlined here. Alternatively, the task could also switch to specifying specVersion: 3.0.

This will probably affect other custom tasks too. However, in your case it seems that only the mentioned task is being used in your project.

Thanks for the quick response and the detailed info.
If this is the case with any custom task, there should be a warning regarding it.
Moreover, I wonder wouldn't it be easier to change the default behaviour: Build all the project dependencies only if a custom task explicitly requires access to them.

Thanks for creating the issue!

Moreover, I wonder wouldn't it be easier to change the default behaviour: Build all the project dependencies only if a custom task explicitly requires access to them.

Yes, you are right. Sadly there is no way to tell for UI5 Tooling whether an existing custom task requires access to dependencies. This is only possible with the newly introduced determineRequiredDependencies callback.

Therefore, we have to assume that all existing custom tasks might require access to dependencies.

The ui5-task-nwabap-deployer custom task has been updated as per pfefferf/ui5-nwabap-deployer#60

Updating the dependency should resolve the performance issue you are facing.