ui5 build (without -a) is building all dependencies by default

[sammok83]

Expected Behavior

When using ui5 build, it shouldn't build all dependencies in the framework section when I'm not specifying -a.

Current Behavior

When using ui5 build, it shouldn't build all dependencies in the framework section when I'm not specifying -a. However it's doing that in the latest version even without specifying -a

In ui5.yaml:

In the terminal output:

Steps to Reproduce the Issue

1. Execute ui5 build preload --clean-dest --include-task=generateCachebusterInfo / ui5 build --clean-dest --include-task=generateCachebusterInfo

Context

• UI5 Module Version (output of ui5 --version when using the CLI): 3.0.3
• Node.js Version: v18.12.1
• npm Version: 9.6.0
• OS/Platform: Windows 10
• Browser (if relevant): Chrome

Log Output / Stack Trace

[flovogt]

Hi @sammok83,
thanks for opening this issue with us. Could you share the complete ui5.yaml and package.json with us, please?
With UI5 Tooling 3.0 custom tasks has to declare if they need dependencies or not. So I guess, the project is using one which is not adjusted yet. See also here #781 (comment).

[sammok83]

Sure:

ui5.yaml:

specVersion: "3.0"
metadata:
  name: testappforsap
type: application
framework:
  name: SAPUI5
  version: "1.84.0"
  libraries:
    - name: sap.ca.ui
    - name: sap.m
    - name: sap.ui.core
    - name: sap.ushell
    - name: themelib_sap_fiori_3
server:
  customMiddleware:
    - name: fiori-tools-proxy
      afterMiddleware: compression
      configuration:
        ignoreCertError: true
        backend:
          - path: /sap
            url: https://testforsap.com:44300
            ws: true
            client: "010"
        credentials:
          username: env:FIORI_TOOLS_USER
          password: env:FIORI_TOOLS_PASSWORD
    - name: fiori-tools-appreload
      afterMiddleware: compression
      configuration:
        port: 35729
        path: webapp
    - name: fiori-tools-servestatic
      afterMiddleware: compression
      configuration:
        paths:
          - path: /resources/sap|/test-resources/sap
            src: "/Users/Sam/Desktop/Development/sap/SAPUI5/custom-sapui5-library/src/sap"
builder:
  customTasks:
    - name: ui5-tooling-transpile-task
      afterTask: replaceVersion
      configuration:
        debug: true
        removeConsoleStatements: true
        transpileAsync: true
        excludePatterns:
          - "lib/"
          - "localService"
          - "test"

package.json:

{
    "name": "testappforsap",
    "version": "0.0.1",
    "description": "",
    "private": true,
    "devDependencies": {
        "@openui5/ts-types": "^1.111.0",
        "@sap/ux-ui5-tooling": "^1.9.1",
        "@ui5/cli": "^3.0.3",
        "ui5-tooling-transpile": "^0.3.7"
    },
    "scripts": {
        "start": "ui5 serve -o test/flpSandbox.html#testapp-manage&/Orders",
        "build": "ui5 build preload --clean-dest --include-task=generateCachebusterInfo",
        "deploy": "npm run build && fiori deploy --config ui5-deploy.yaml -- -y && rimraf archive.zip"
    }
}

[flovogt]

Its indeed the reason I described above. I'll request an adjustment of the ui5-tooling-transpile package.

[flovogt]

This issue is not fixable by UI5 Tooling itself. Therefore closing this issue here. Further discussions can be added to the mentioned PR.

[flovogt]

Issue is fixed with ui5-tooling-transpile version 0.4.1.