SAP/ui5-webcomponents-ngx

Standardize available themes

N1XUS opened this issue · 2 comments

N1XUS commented

Feature Request Description

Currently, we don't have one source of truth when it comes to the list of available themes:

  • sap-theming package exposes all themes that can be used in application:
    image

  • ui5-webcomponents-theming package exposes all themes except for sap_fiori_3_light_dark:
    image

  • fundamental-styles package exposes new themes (belize is skipped):
    image

With such different lists of supported themes it becomes hard to actually sync theming across multiple libs in one app.

Proposed Solution

A clear and concise description of the solution you would like to have. -->
Theming package generator should know which set of themes can be used with components used in app.
I mean, if we have ui5-webcomponents AND fundamental-styles, we should exclude belize and sap_fiori_3_light_dark since these themes are not supported by both libraries at the same time.
On the other hand, if application has only ui5-webcomponents, we should not restrict belize theme.

Proposed Alternatives

Additional Context

Priority

  • Low
  • Medium
  • High
  • Very High

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

  • Organization: {...}
  • Business impact: {...}
github-actions commented

Hello @N1XUS, thank you for using ui5-webcomponents-ngx! The ui5-webcomponents-ngx team will triage your issue as soon as possible.

g-cheishvili commented

The best way would be that provider gives list of available themes and then the main service queries both(or more) and understands which ones are available for current application, given the providers