SAP/ui5-webcomponents-ngx

Ng-add does not add ui5 theming provider

g-cheishvili opened this issue · 1 comments

Bug Description

When you install the package with ng add and use theming, it should also add theming provider service module in app.module alongside theming module

Expected Behavior

Working theming

N1XUS commented

@g-cheishvili actually, schematics are importing Ui5ThemingModule which contains instance of theming service, so providing the service itself is not needed anymore: https://github.com/SAP/ui5-webcomponents-ngx/blob/main/libs/ui5-angular-theming/src/ui5-theming.module.ts#L15