SAP/ui5-webcomponents-ngx

Select: No FormControl support

ilhan007 opened this issue · 3 comments

ilhan007 commented

Created the issue on behalf of SAP Build Process Automation:
Select - FormControl support is missing.

Expected Behavior

Steps to Reproduce

  1. Go to '...'
  2. ...
  3. ...

Isolated Example

Context

  • UI5 Web Components version: {...}
  • UI5 Web Components for Angular version: {...}
  • Angular Version: {...}
  • OS/Platform: {...}
  • Browser: {...}
  • Affected component: {...}

Log Output / Stack Trace / Screenshots

{...}

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: {...}
  • Business impact: {...}
ilhan007 commented

Hello @droshev this is one of the latest issues raised. Meanwhile I will ask the authors for more information. Thank you.

timogeib commented

FormControl not working at all -> No value accessor for form control error in console
image
image

ilhan007 commented

Hello @mikerodonnell89 @g-cheishvili

The FormControl support of the Select directive should be fixed if you update the ui5-webcomponents-ngx wrappers to the latest ui5-webcomponents as in the latest version we introduced a "value" property to the Select web component (that is marked as formProperty), so that the generated wrapper will extend GVA and the default setters and getters that rely on having a "value" property will work as we added "value" property to the Select web component

Actually I tried to update but there are some build issues to fix:
#103