SAP/ui5-webcomponents-react

[RadioButton - RadioButton Groups ]: [its not grouping the radiobutton and their label and their mail title]

Closed this issue · 5 comments

Describe the bug

I have attached a screenshot below in screenshots

In radiobutton groups, its not grouping the radiobutton and their label and their mail title

Link: https://sap.github.io/ui5-webcomponents-react/?path=/story/inputs-radiobutton--radio-button-groups

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

No response

Screenshots or Videos

image

UI5 Web Components for React Version

1.28.1

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

windows

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.

Hi @vaitheeswari21

unfortunately I don't understand where you see a problem. In the screenshot you posted there's both a vertical and horizontal group of RadioButtons which are grouped by the name prop. Please provide more details or clarify what specific issue you are encountering so that we can assist you.

@Lukas742 You can take a horizontal group ,

In that its not reading like option a of horizontal groups like that.

Currently just announcing like options a alone.

I hope you understood my concern

Thanks

So, I take it that it's an accessibility issue you're concerned about?
I've checked and in my opinion the screen reader announcement for RadioButtons inside a group are correct. Only our example needed some improvement. The linked PR will add the radiogroup role and a label to the container of each group. Please note, that these attributes should be added by app developers, as we don't offer any group/container component for radio button groups.

If you think that something else is missing or not working properly, please explain exactly what the wrong/missing value is and what value you would expect.

@Lukas742 yes this is an accessibility issue.

Could you please send me that Pr where you changed your opinion?

It's shown directly above my previous comment and also linked to this issue 😉

#5825