[AnalyticalTable]: [In entire application for ‘XX’ column header within ‘XX’ table, 4 sided borders are not properly visible, it is visible in dotted border for the users and when we selecting any header row only 3 sided border are visible.]
jadhavarjun opened this issue · 10 comments
Describe the bug
In entire application for ‘XX’ column header within ‘XX’ table, 4 sided borders are not properly visible, it is visible in dotted border for the users and when we selecting any header row only 3 sided border are visible.
Reproduction steps:
- After clicking on link choose Horizon High Contrast Black/Horizon High Contrast White Theme
- Click on any table row data you will able to see the selected that selected text 4 sided borders are not properly visible, it is visible in dotted border.
Isolated Example
No response
Reproduction steps
...
Expected Behaviour
User should be able to see 4-sided borders for the UIs and the focus should be strong for all the corners.
Screenshots or Videos
UI5 Web Components for React Version
^1.16.3
UI5 Web Components Version
^1.14.0
Browser
Chrome
Operating System
No response
Additional Context
No response
Relevant log output
No response
Organization
No response
Declaration
- I’m not disclosing any internal or sensitive information.
Hi @jadhavarjun
merging a PR only means that the commit made it's way to our codebase, not that it has been published. So, the fix will only be available with our next release.
Hi @Lukas742 Could you please let me know when it will next release. and after release what should necessary changes we need to do from our site.
we will most likely release a new version tomorrow or early next week.
Since this is only a bug fix, all you need to do is update your dependencies. :)
🎉 This issue has been resolved in version v1.29.3 🎉
The release is available on v1.29.3
🎉 This issue has been resolved in version v2.0.0-rc.0 🎉
The release is available on v2.0.0-rc.0
Your semantic-release bot 📦🚀
Hi @Lukas742
How can i check this issue. could you please provide url or detail for testing this border related issue.
the fix is available in both version 1.29.3 and our pre release version 2.0.0-rc.0, so to test it you have to update your dependencies.
Hi @Lukas742
Thanks for response. Just for confirmation. Can i see this changes on UI5component storybook ? because I can't see here https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-analyticaltable--docs&globals=theme:sap_horizon_hcb
There above in right corner v1.29.4 version in storybook
Yes, the changes are there. The focus border now uses the correct offset in every theme and is not overlapping the cell border (e.g. when selected & focused) anymore.
Could you elaborate on what fix you expected and what is still missing?