SAP/ui5-webcomponents-react

[package.json]: Conflicting peer dependency

Opened this issue · 1 comments

jpw1012 commented

Describe the bug

"react-table": "7.8.0" has a peer dependency of "react": "^16.8.3 || ^17.0.0-0 || ^18.0.0"
This conflicts with current peer-dependency "react": "^18 || ^19".

My project has a dependency of "react": "^19.0.0". I see warnings when running npm install: Conflicting peer dependency: react@18.3.1

Isolated Example

No response

Reproduction steps

npm install react react-dom
npm install @ui5/webcomponents @ui5/webcomponents-react @ui5/webcomponents-fiori
outputs:
npm warn ERESOLVE overriding peer dependency

Expected Behaviour

react 19 should not cause any conflicting dependency warnings. We do not see any issues using react 19, however we do not use the Analytical tables.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: react-table@7.8.0
npm warn Found: react@19.0.0
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   6 more (@tanstack/react-virtual, @ui5/webcomponents-react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^16.8.3 || ^17.0.0-0 || ^18.0.0" from react-table@7.8.0
npm warn node_modules/@ui5/webcomponents-react/node_modules/react-table
npm warn   react-table@"7.8.0" from @ui5/webcomponents-react@2.5.0
npm warn   node_modules/@ui5/webcomponents-react
npm warn
npm warn Conflicting peer dependency: react@18.3.1
npm warn node_modules/react
npm warn   peer react@"^16.8.3 || ^17.0.0-0 || ^18.0.0" from react-table@7.8.0
npm warn   node_modules/@ui5/webcomponents-react/node_modules/react-table
npm warn     react-table@"7.8.0" from @ui5/webcomponents-react@2.5.0
npm warn     node_modules/@ui5/webcomponents-react

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
Lukas742 commented

Hi @jpw1012

unfortunately, we're still stuck on react-table v7, which doesn’t list React 19 in its peer dependencies. Upgrading will most probably require a complete rebuild of the table, something we haven’t had the capacity for yet.

At the start of the new year, we plan to prioritize this topic, but it will likely take some time as our capacity is still limited.

That said, we’re already running React 19 internally, and our tests use both React 18 and React 19. So, while the peer dependency error is far from ideal, React 19 shouldn't break the implementation of the AnalyticalTable (or anything else).

  • 👍1