SAP/ui5-webcomponents

[Feature Request]: Custom indentation width for Tree component

Opened this issue · 5 comments

k-daryl commented

Feature Request Description

Currently the indentation is defined by an indent variable of 0.5rem (ex. defined in --_ui5-v2-5-0-tree-indent-step) times the 'step' which is defined internally.

For our use case, due to our design would like to customized the indentation constant to a higher value, however this is not exposed for us to change.

Proposed Solution

Please allow changing of the indentation constant. If possible, our product is currently using 1.24.13

Proposed Alternatives

No response

Organization

SAP Analytics Cloud

Additional Context

No response

Priority

None

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
Valkanister commented

"Hello @SAP/ui5-webcomponents-topic-p , take a look of this feature request for the Tree. Also advise if this can be done in 1.24 or if an upgrade to 2.0 is needed.

Kind regards, 

Georgi

SAP Development Support

PetyaMarkovaBogdanova commented

Hi @k-daryl ,
thank you for suggesting this enhancement.
For a change like that you should first consider gaining a designer approval by opening a ticket using our innersource process.
We will be happy to implement it once approved.
Best regards,
Petya Markova.
UI5 Web Components Developer

k-daryl commented

Thanks for the reply Petya, I will first follow through with the innersource process

k-daryl commented

Hi @PetyaMarkovaBogdanova, after consultation with the design team, the following discoveries were found.

Based on the Tree Horizon rules, there should be an indentation of 1.5rem, until the user starts to dig deep down in the tree, when the indentation will change, also according to the specification.

I see that in V2 of UI5WC, the indentation step is now set at 1.5rem (for --_ui5-v2-6-2-tree-indent-step) instead of set to 0.5rem in V1.

Can we please update this request to be to fix V1 with 1.5rem for indentation? as this issue seems more like a bug and only fixed in V2.

Thanks,
Daryl

dobrinyonkov commented

@SAP/ui5-webcomponents-topic-p, please check if tree item indentation is according to the visual spec and align accordingly, thanks!