SCENE-CE/mirador-annotation-editor

Check comportement when switching canvas

Opened this issue · 7 comments

Our pannel check manifest type at the top logic but what if a manifest contain differents canvas ?

@Drilio @geourjoa A test manifest with different media types on canvases is here : https://files.tetras-libre.fr/dev/Heterogeneous-media-on-several-canvases.json

Our major problems come from annotationDrawing, everything in this part of code is based on this logic :
is there an Image ? If not do the video thing..
But this logic doesn't work with the way Mirador handle differents canvas type.

I'll create a branch and try some major changes to see if a change on how the logic is handle could lead to something better.

What we are intersting in is :
0>__jsonld>items>0>items>0>body>type

Image Canvases information :

Image

Video Canvases information:

Image

Audio Canvases Information :

Image

Canvases = Actual displaying canvas

Problem :
The app crash when switching canvas while panel annotation is selected with template.

Reproduce :

  • open pannel annotation
  • choose a template
  • switch canvas
  • The canva size is not refreshed when switching video to image

To reproduce use : https://files.tetras-libre.fr/dev/Heterogeneous-media-on-several-canvases.json

  • Go to image (canva 1)
  • Draw a target
  • Go to video (Canva 2)
  • Move the object
  • Return to image (canva 1)
  • The object can only move on the video size