SCIInstitute/Cleaver

SaveNRRDFile is using AbstractScalarField + ITK Version broken.

Opened this issue · 3 comments

jonbronson commented

NRRDTools::saveNRRDFile is now using AbstractScalarField which is in general not guaranteed to be a 3D array of scalar values. This creates a black-box sampling that the user cannot control and needs to be reverted back to either a Concrete FloatField or a possibly a templatized method ScalarField.

jonbronson commented

Function signature restricted back to FloatFields in change f5f02a6

The ITK version of the save method is still incorrect, as it's using the geometry bounds of the scalar field rather than the data field. Origin and scale/spacing information is also lost.

jonbronson commented

Fixed sampling size of the ITK version of SaveNRRDFile to properly use dataBounds size instead of geometry bounds size in change 9b6f37f

jonbronson commented

Remaining open issues with ITK Version of SaveNRRDFile:

  • Geometry bounds lost.

Lowering priority.