GH Actions R CMD Chk Failures
pbulsink opened this issue · 7 comments
Recently CMD Chk fails on PR/Push for ubuntu tasks. Even previously passing checks fail.
#189 didn't work. I might wait a week, I think the issue is with 'reticulate' so I'll wait for more bug reports to pop up and a fix to roll out to GH Actions
Do we know anything about this?
Not yet. I'll do more research but I worry we'll have to remove the affected function(s) and just provide the advice vignette and a link to reticulate documentation.
I don't want CRAN checks to end up with the same issue blocking a bugfix release in the future.
Damn yeah makes sense
So I rechecked the reticulate documentation.
Here they briefly, but essentially suggest that we offer a convenience function that wraps reticulate to install the python package we need (i.e. fastf1). Why don't we do that instead of all of the virtualenv stuff? They suggest (wisely) that a user may wish to have multiple reticulate based packages active at once in one virtualenv, this approach simplifies that possibility.
Yes that makes perfect sense and is more user friendly too