SESA/EbbRT

NodeAllocator bug in new defaults logic

Closed this issue · 0 comments

I am working on a fix... using this to learn about how to push a fix

BUG: Release hosted build can expose a initialization bug in the NodeAllocator that will result in defaults not being properly initialized when the first node allocation is done such that a node allocate with no parameters will lead to qemu being invoked with bad arguments:

+ exec qemu-system-x86_64 -m 0G -smp cpus=0 -cpu host -serial stdio -display none -enable-kvm -netdev tap,script=no,downscript=no,ifname=tap0,id=net0,vhost=on,queues=0 -device virtio-net-pci,netdev=net0,mac=02:42:ac:14:00:02,mq=on,vectors=2 --gdb tcp:0.0.0.0:1234 -kernel /root/img.elf -append 'host_addr=2886991873;host_port=37807;allocid=0'

Fix is to remove the class wide initialization from the rep creation path and move it to a ClassInit