Nodes have incorrect color
Closed this issue · 4 comments
Code:
$ dig valibox. A
$ curl -4 valibox. >/dev/null
Result:
Expected result:
"Valibox." to be green, and the ipv4 to be assigned to it.
After consulting @tjeb: this may be by-design (since valibox traffic is ignored). However, for DNS queries, valibox-traffic is not ignored.
Question is: how do we proceed?
We should probably ignore Valibox DNS queries as well, at least in the GUI.
actually, come to think of it, this will happen with any IP address that is in the ignore list; DNS queries that resolve to that IP will still be shown, but the traffic will not. I am leaning towards ignoring those queries too but it doesn't really feel right...
+1 for hiding the dns queries. That's what ignore implies. @mdavids ?
Hmm. The generalized approach needs an additional set of protocol messages from the kmod to spind (updates to ignore/block/except lists), or the hard assumption that spind is the only one talking to the kmod. We will need those anyway (if/when we want host-based lists) but it feels out of scope for this particular issue (that is to say, i don't want to rush that to get this fixed). I could hard-special-case these particular names but I rather not. If we run into this again before extending the protocol we can do that. Otherwise I want to close this and add it to #42