The last PR #70 removed my changes

Question

The last PR #70 removed my changes

Closed this issue 2 years ago · 5 comments

Hi, I just wanted to work on #42 and create a PR for this issue. However, I noticed that my changes from PR #68 and #69 are not in the main branch anymore. I found out that the last PR #70 removed my changes. Is this intended?

Answer 1 · 2022-08-20T09:13:39.000Z

This is not intended. It looks like some misoperations... I will try to figure out soon.

Please feel free to tell anything !!!! thanks !

Answer 2 · 2022-08-20T09:44:55.000Z

@simisimon For #68 and #69 Can you please create new PRs as that will make it easier. Our team is really busy at the moment, so did not do well in managing PRs. Sorry for this

Answer 3 · 2022-08-20T09:45:38.000Z

We will later carefully follow steps to review every change.

Answer 4 · 2022-08-20T10:03:09.000Z

@simisimon I will manually recover this issue during this weekend. Already make changes to the main branch. Thanks for pointing this out!

Answer 5 · 2022-08-20T10:25:48.000Z

No problem. I will create new PR's.