HTML is getting difficult to maintain
Closed this issue · 7 comments
I'm looking at the widget branch which will add the todo list and I think the HTML is getting difficult to maintain. It's not nice to have the HTML for the calculator and the todo list in one place.
I think we should look at using Knockout components. This way, the HTML for the calculator and todo list can be separate from the main page and even loaded dynamically using Require JS.
I think we should look at using Knockout components.
http://knockoutjs.com/documentation/component-overview.html
HTML binding is something different and not what we would want to use. Having said that, as much as I really dislike the approach, you could probably get it working by doing this:
html: calculatorHtml.calcHtmlCode but it's really not pretty at all.
You would also have to edit calculator.js to use ES6 backticks to wrap the HTML as you are using a multi line string i.e. ` instead of '
You could use single quotes as you are doing now but you would have to escape the end of every line with a backslash.
That's correct, because the HTML has been rendered but data-bind attributes within the HTML were ignored.
We should be looking at using knockout components instead. I'll see if I can put in a PR for it.
I've created a PR for this here #48. Please checkout the updated readme.
The PR converts the calculator to a component. Feel free to go ahead and checkout the branch and convert the todo list to a component as well.