SOCI/soci

File "private/soci-trivial-blob-backend.h" missing

Spixmaster opened this issue · 5 comments

Spixmaster commented

@Krzmbrzl, the commit #992 includes #include <private/soci-trivial-blob-backend.h> which is not present when installed with CMake.

Krzmbrzl commented

See my revamp cmake PR. I think there this should be fixed

  • 👍1
Spixmaster commented

#1118 for reference.

  • 👍1
vadz commented

Private headers are not supposed to be installed, so if this header is used by the public headers, it can't be private.

I.e. it's not (just) a build system problem, it's a problem with the header name/path.

  • 👍1
Spixmaster commented

The header is used two times, here and here.

Krzmbrzl commented

I had another look at this and am now in line with what @vadz said. That is, I misused private headers. Consequently, this is fixed in #1165

  • 👍1