STARIONGROUP/COMET-SDK-Community-Edition

[Update] PermissionService to refactor the behavior of PersonAccessRightKind.MODIFY_IF_PARTICIPANT

samatstariongroup opened this issue · 1 comments

samatstariongroup commented

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the COMET-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

A new PersonAccessRightKind is required to allow a Person to create new models without have read access to all models. Currently we only support creating a model when there is PersonAccessRightKind.Modify on EngineeringModelSetup which gives a person access to all models.

When serializing from the server we have to make sure that this new PersonAccessRightKind.CREATE_MODEL is ignored when a version 1.0.0, 1.1.0 or 1.2.0 is requesting the data.

Instead of adding a new PersonAccessRightKind the behavior of the existing MODIFY_IF_PARTICIPANT will be updated so that in case a PersonRole has this, then the Person associated is allowed to create models

see #275 as well

Steps to Reproduce

System Configuration

  • COMET version:
    • CDP4Common:
    • CDP4JsonSerializer:
    • CDP4Dal:
    • CDP4JsonFileDal:
    • CDP4ServicesDal:
    • CDP4WspDal:
    • Other:
  • Environment (Operating system, version and so on):
  • .NET Framework version:
  • Additional information:
samatstariongroup commented

Instead of adding a new PersonAccessRightKind the behavior of the existing MODIFY_IF_PARTICIPANT will be updated so that in case a PersonRole has this, then the Person associated is allowed to create models