Allow creation of ParameterValueSet with ValueArray that have values
antoineatstariongroup opened this issue · 1 comments
Prerequisites
- I have written a descriptive issue title
- I have verified that I am running the latest version of the COMET Web Services
- I have searched open and closed issues to ensure it has not already been reported
Description
It is not possible to create a Parameter with ParameterValueSet that already contains values inside the ValueArray: ParameterValueSet are create via side-effect server side. Same appears when modifying the Option/State dependency.
It should be possible to allow by-passing the side-effect if all provided ParameterValueSet are valid for the Parameter (all possible combination for Option/State dependency present).
On Create:
- Do not create ParameterValueSet if the payload is valid
On Update:
- Keep ParameterValueSet where the Option/State dependency are still fine, create or delete invalid once
- If some ParameterValueSet are provided while updating the Option/State dependency of the Parameter, keep them if payload is valid
Steps to Reproduce
System Configuration
- COMET Web Services version:
- CDP4Common:
- PostrgreSQL:
- Other:
- Environment (Operating system, version and so on):
- .NET Framework version:
- Mono version:
- Additional information:
I propose a way forward so we don't change the server behaviour too much and we add a dedicated section to the POST message.
now it looks like:
{
"_create": [],
"_update": [],
"_delete": [],
"_copy": [],
"_values":[]
}
in the Values
property we can put a list of ParameterValueSets (with reference to the container Parameter or PArameterOverride.