STAT545-UBC-hw-2018-19/hw02-liming17

TA comments

Opened this issue · 0 comments

#bad
ggplot(gapminder, aes(year, pop)) + scale_y_log10() + geom_point(alpha=0.1)

#good
ggplot(gapminder, aes(year, pop)) + 
    scale_y_log10() + 
    geom_point(alpha=0.1)
  • Use proper spacing e.g., alpha = 0.1 instead of alpha=0.1.

  • In chuck/Inline comments people generally avoid to explain "what" the code does because . Instead they use "why" comments. Some of your comments explained what the code does, which is information that the code already contains.

  • Overall you have done a great job!