TA comments
Opened this issue · 0 comments
Rashedul commented
-
Your readme file had a good description of your directory and you linked the files which was great.
-
You can add chunk names here: https://github.com/STAT545-UBC-students/hw02-liming17/tree/master/hw02_files/figure-gfm
-
To attach packages you can use
suppressPackageStartupMessages()
function to suppress messages. -
Use proper indentation for readability. For example,
#bad
ggplot(gapminder, aes(year, pop)) + scale_y_log10() + geom_point(alpha=0.1)
#good
ggplot(gapminder, aes(year, pop)) +
scale_y_log10() +
geom_point(alpha=0.1)
-
Use proper spacing e.g.,
alpha = 0.1
instead ofalpha=0.1
. -
In chuck/Inline comments people generally avoid to explain "what" the code does because . Instead they use "why" comments. Some of your comments explained what the code does, which is information that the code already contains.
-
Overall you have done a great job!