HAL_RTCEx_SetTamper_IT Incorrect on STM32L4P5xx and STM32L4Q5xx

[badcf00d]

The HAL function HAL_RTCEx_SetTamper_IT does not initialise the trigger level properly in TAMP->CR2, the function HAL_RTCEx_SetTamper seems correct though. I suspect the updated code from HAL_RTCEx_SetTamper just needs to be copied across to HAL_RTCEx_SetTamper_IT.

Correct:

stm32l4xx_hal_driver/Src/stm32l4xx_hal_rtc_ex.c

Lines 1767 to 1779 in e494650

	/* Trigger and Filter have exclusive configurations */
	assert_param(((sTamper->Filter != RTC_TAMPERFILTER_DISABLE) && ((sTamper->Trigger == RTC_TAMPERTRIGGER_LOWLEVEL) || (sTamper->Trigger == RTC_TAMPERTRIGGER_HIGHLEVEL)))
	|| ((sTamper->Filter == RTC_TAMPERFILTER_DISABLE) && ((sTamper->Trigger == RTC_TAMPERTRIGGER_RISINGEDGE) || (sTamper->Trigger == RTC_TAMPERTRIGGER_FALLINGEDGE))));
	/* Configuration register 2 */
	tmpreg = tamp->CR2;
	tmpreg &= ~((sTamper->Tamper << TAMP_CR2_TAMP1TRG_Pos) | (sTamper->Tamper << TAMP_CR2_TAMP1MSK_Pos) | (sTamper->Tamper << TAMP_CR2_TAMP1NOERASE_Pos));
	/* Configure the tamper trigger bit */
	if ((sTamper->Trigger == RTC_TAMPERTRIGGER_HIGHLEVEL) || (sTamper->Trigger == RTC_TAMPERTRIGGER_FALLINGEDGE))
	{
	tmpreg |= (sTamper->Tamper << TAMP_CR2_TAMP1TRG_Pos);
	}

Incorrect:

stm32l4xx_hal_driver/Src/stm32l4xx_hal_rtc_ex.c

Lines 1928 to 1936 in e494650

	tmpreg = tamp->CR2;
	/* Clear the bits that are going to be configured and leave the others unchanged */
	tmpreg &= ~((sTamper->Tamper << TAMP_CR2_TAMP1TRG_Pos) | (sTamper->Tamper << TAMP_CR2_TAMP1MSK_Pos) | (sTamper->Tamper << TAMP_CR2_TAMP1NOERASE_Pos));
	if (sTamper->Trigger != RTC_TAMPERTRIGGER_RISINGEDGE)
	{
	tmpreg |= (sTamper->Tamper << TAMP_CR2_TAMP1TRG_Pos);
	}

[ALABSTM]

Hi @badcf00d,

Thank you for having reported. Looks like you're right. The issue will be forwarded to our development teams to be fixed. I will keep you informed.

With regards,

[ALABSTM]

ST Internal Reference: 174977

[KRASTM]

Fixed in 67bb79e