SUI-Components/sui

🪲 The last items of the sidebar menu are unreachable

turolopezsanabria opened this issue · 4 comments

Package

@sui-studio

Description

The last items of the sidebar menu are unreachable because there's no padding between the last element and the container

221004 - Menu items are unreachable

Steps to Reproduce

  1. Grab a mobile device (I've used an iPhone)
  2. Go to sui-components.vercel.app
  3. Scroll the menu to the bottom
  4. Try to select primitive-injector

Expected behavior: [What you expect to happen]

The menu items should always be reachable

Additional Information

To fix it: Adjust the height of .sui-Studio-sidebar

❌ 100vh
✅ 100vh - height of .sui-Studio-navHeader (48px)

Also, please double the padding-bottom of the menu

❌ 16px
✅ 32px

ays14 commented

hey @turolopezsanabria , let me take this up.

I am unable to open http://www.sui-studio.now.sh/, it fails to establish an HTTP connection

sure @ays14! Assigned to you

Sorry the link was wrong, this is the right one: https://sui-components.vercel.app/
thnx

ays14 commented

Thanks for the correct link, I will get started on this.

ays14 commented

@turolopezsanabria I have opened a PR (attached above) for the fix. Please review.