SUI-Components/sui

[sui-mono] CHANGELOG.md is not being generated

xcafebabe opened this issue · 1 comments

xcafebabe commented

Package

@s-ui/mono@1.41.0

Description

After a component release (npm run release) in a mono repository, CHANGELOG.md is not being generated, actually current CHANGELOG.md from the component is wiped out.

So far it's only happens in my Linux setup (Manjaro 18.0.4)

Steps to Reproduce

  1. Clone and install sui-components
  2. sui-mono changelog components/atom/button

Expected behavior: Nothing will change in components/atom/button/CHANGELOG.md

Actual behavior: File content is wiped out from components/atom/button/CHANGELOG.md and you can read only

# Change Log

All notable changes to this project will be documented in this file.

Reproduces how often: Always in Linux setup (Manjaro 18.0.4)

xcafebabe commented

The issue could be here https://github.com/SUI-Components/sui/blob/master/packages/sui-mono/bin/sui-mono-changelog.js#L72-L74

Have the impression that the node process is ending before finish writing changelog file. I tested locally and something like this is working

      .on('end', () => {
        output.end(() => resolve(outputFile))
      })
      .on('error', error => {
        output.destroy(error)
        reject(error)
      })
  • 👍1