SUSE/SAPHanaSR

ATTR_NAME_HANA_FILTER - 3rd value should be variable SAPHanaFilter and not static string

Opened this issue · 3 comments

ATTR_NAME_HANA_FILTER=("hana_${sid}_glob_filter" "props" "ra-act-dec-lpa")

SAPHanaFilter=$(get_hana_attribute "X" "${ATTR_NAME_HANA_FILTER[@]}")

declare -u SAPHanaFilter='ra-act-dec-lpa'

to be more precise
SAPHanaFilter is already declared

declare -u SAPHanaFilter='ra-act-dec-lpa'

use here instead of specifying same string again
ATTR_NAME_HANA_FILTER=("hana_${sid}glob_filter" "props" "ra-act-dec-lpa")
-->
ATTR_NAME_HANA_FILTER=("hana
${sid}_glob_filter" "props" "${SAPHanaFilter}")

Still unclear what is the real benefit.

currently the filter values 'ra-act-dec-lpa' are defined 2times .. the first declaration has no meaning .. if you want to change the default filter you have to change it in the second occurence

ATTR_NAME_HANA_FILTER=("hana_${sid}glob_filter" "props" "ra-act-dec-lpa")

this is different again for SAPHana and SAPHanaTopology