Start gating PRs with the linting from CI
Closed this issue · 2 comments
Currently, PRs can be merged even if their helm linting fails. This makes linting the other helm charts less useful, as everything will be red from then onwards, and responsibility on code health dilutes.
I propose to gate the PRs with the linting pipeline https://github.com/SUSE/cloudfoundry/tree/master/ci/pipelines/helm-charts-check, only being able to merge with explicit approval.
This protects us from #158
@bikramnehra is looking at a mechanism to run the linter as a Github Action (pending SUSE's Github status to allow private repos to run it) or as another Concourse job. Would that help handle this scenario?
ref: https://github.com/SUSE/kubernetes-charts-suse-com/actions/runs/146484622
@gaktive this should be taken care of as we would now only lint the changed charts instead of everything