[doc] Issue in "Post-installation tasks"
Closed this issue · 8 comments
In the Post-installation tasks section there is the ingress.yaml cannot work as is, the one I've used to get the SAP installation done is the one below:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
annotations:
nginx.ingress.kubernetes.io/backend-protocol: HTTPS
nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
nginx.ingress.kubernetes.io/proxy-body-size: "0"
nginx.ingress.kubernetes.io/proxy-buffer-size: 16k
nginx.ingress.kubernetes.io/proxy-connect-timeout: "30"
nginx.ingress.kubernetes.io/proxy-read-timeout: "1800"
nginx.ingress.kubernetes.io/proxy-send-timeout: "1800"
nginx.ingress.kubernetes.io/secure-backends: "true"
name: vsystem
spec:
defaultBackend:
service:
name: vsystem
port:
number: 8797
ingressClassName: nginx
tls:
- hosts:
- "<hostname FQDN must match SSL certificate>"
secretName: vsystem-tls-certs
@KevinKlinger @uschairer would you mind having a look ? Thank you!
@Wabri The only difference is the apiVersion, right?
You're right in that case as ingress has been changed since K8s version 1.22 (https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122)
@chabowski Do you want me to correct it and create a new PR?
Hi @KevinKlinger yes please, that would be nice :-). Thank you! (please don't forget to refresh your repo to the latest status of main - there had been changes ;-) )
@Suse-KevinKlinger there are also the spec are different, similar of course, but not the same as I've used.
spec.rules are replaced by spec.defaultBackend
Hi @Suse-KevinKlinger - would you mind updating the doc and do a PR? Thank you very much for your help :-).
@chabowski done.
PR: #401
As discuess in private chat with @Wabri , the rules part will stay as the defaultBackend would change the behavior of the ingress and a rule is more specific.
@Suse-KevinKlinger super - thank you so much! I will merge the PR, and the doc will be republished by the end of this week.
Closing issue as resolved