SWIFTSIM/SWIFT

Issues with CoolingHalo examples

mmlinford opened this issue · 0 comments

Hello,

There seem to be a few issues with the CoolingHalo and CoolingHaloWithSpin examples:

  • A script radial_profile.py is in run.sh, but there is none in the project
  • I had to decrease dt_min to 1e-8 or it complained about parts wanting time-steps below the dt_min
  • internal_energy_profile.py refers to unrelated Hydrostatic_####.hdf5 files
  • test_energy_conservation.py refers to SoftenedIsothermalPotential:vrot, which doesn't exist anymore since softened isothermal potential was removed
  • parameters passed to the python scripts from run.sh don't make sense. The python scripts seem to expect different numbers of parameters than what the run.sh scripts pass in. One of them doesn't parse correctly ("2." can't be parsed as an int)

So it isn't really possible to run those examples as they are right now.