Saibot393/perceptive

[Feature Request] Use namespaced flags

Closed this issue · 1 comments

Perceptive currently pollutes the "global" flag space with a variety of not-easy-to-identify flags. As a developer, I would prefer if these were kept under the standard "module ID" namespace, to make them easier to handle when copying, deleting, checking... etc.

Flags I found, and suggested good-hygiene form:

flags.canbeLockpeekedFlag        -> flags.perceptive.canbeLockpeekedFlag
flags.DoorHingePositionFlag      -> flags.perceptive.DoorHingePositionFlag
flags.DoorMovementFlag           -> flags.perceptive.DoorMovementFlag
flags.DoormovingWallIDFlag       -> flags.perceptive.DoormovingWallIDFlag
flags.DoorSwingRangeFlag         -> flags.perceptive.DoorSwingRangeFlag
flags.DoorSlideSpeedFlag         -> flags.perceptive.DoorSlideSpeedFlag
flags.DoorSlideStateFlag         -> flags.perceptive.DoorSlideStateFlag
flags.DoorSwingSpeedFlag         -> flags.perceptive.DoorSwingSpeedFlag
flags.DoorSwingStateFlag         -> flags.perceptive.DoorSwingStateFlag
flags.LockpeekedbyFlag           -> flags.perceptive.LockpeekedbyFlag
flags.LockPeekingWallIDsFlag     -> flags.perceptive.LockPeekingWallIDsFlag
flags.LockPeekPositionFlag       -> flags.perceptive.LockPeekPositionFlag
flags.LockPeekSizeFlag           -> flags.perceptive.LockPeekSizeFlag
flags.PeekingDCFlag              -> flags.perceptive.PeekingDCFlag
flags.PreventNormalOpenFlag      -> flags.perceptive.PreventNormalOpenFlag

That is very strange and should not be happening. I absolutely agree with you that they should be under the perceptive name space.
From what it seems, a synching method was at fault. That should now be fixed with v3.5.9. As far as i can tell, only special walls that were managed by perceptive specifically were affected by this bug.