Salamek/PplMyApi

Sender for package is not required

Closed this issue · 3 comments

JanGalek commented

Sender for package is not required, but constructor of Package need it. @Salamek Do you want I send PR ?

Salamek commented

@JanGalek well we have problem here,

Sender $sender,
Recipient $recipient,
SpecialDelivery $specialDelivery = null,

After Sender there is another required parameter... that means we need to change order of parameters to:

Recipient $recipient,
Sender $sender = null,
SpecialDelivery $specialDelivery = null,

That is BC breaking change...
And Label generator needs Sender to be set... (or sender is also not required to be printed on label ?)

PS: This project was originaly build on top of "beta" documentation and this stuff wasnt there yet...

JanGalek commented

@Salamek We work with CreatePackages only.

PPL support say that, someting they have problem when they return package whitch have sender. Its problem of PPL.

Maybe do this change for version 2.x.x ? And highlight it to @deprecated for version 1.x.x ?

Salamek commented

This is closed by PR #21

  • 👍1