Feedback
Closed this issue · 2 comments
Nice! This will be a cool project. Feedback below. Please respond.
-
What is a 'survey'? it looks like it has many polls, but doesn't belong to any user (no user_id). how are they created? It's not clear how they fit into the picture
-
Should a poll's token be unique? It seems like it should
-
Have a root view to deliver your application. right now it looks like you are only deliver a sign up and sign in page.
-
Since the 'direction' column in 'votes' is binary, make the data-type boolean. It'll be way more efficient
5)In your votes api, you talk a lot about tags. Not sure what you meant
Hey @ailadson, thanks for the review and for sitting down to chat with me today. I've blown out the review into individual issues and have fixed a few of them already, and will have the remainder fixed by tomorrow. Sorry again for wasting your time.
Thanks!
@ailadson, all issues have been closed. Thanks again for the feedback!