SamSaffron/MiniProfiler

results-index view broken in latest master

Closed this issue · 2 comments

Hi, I've been looking into using the latest master and have found that the 'results-index' view broken.

I've produced a fix on my fork that gets it working again, but I haven't submitted a pull request as I'm unsure whether the fix is appropriate since I've added just enough to get it working. A wider re-factor may be appropriate so ensure the 'results-index' is consistent with the the way the 'results' view is produced.

Please provide feedback. I'm happy to help, by either submitting the fix as a pull request, or adapting the fix to be consistent with the re-factoring described above, though I would require some guidance if you request the latter.

I blame @SamSaffron for that view - I always forget about it :)

Submit the pull request for the fix, for now, please. If you want to do any refactoring, feel free!

I'm going to add a link to that /results-index page on the popup itself, so it's not forgotten again.

Thanks!

Sorry for the delay in replying. I've submitted pull request #119. I'll have a look at the potential refactor.