Samsung/ONE-vscode

[Toolchain] Ask user to set github token

dayo09 opened this issue · 2 comments

dayo09 commented

What?

To use ONE Toolchain, user need to set github token in vscode settings.
Currently, it fails on run without token.
Let's give direction to the user explicitly.

#1598

After setting the default toolchain as onecc-docker latest, I clicked the run button on my config file and it fails on rate limit exceeded for url. I thought the image was installed because I got the default toolchain.
...

onecc-docker: error: 403 Client Error: rate limit exceeded for url: https://api.github.com/repos/Samsung/ONE/releases/latest

To resolve this issue, you need to set GitHub Token in Settings (Settings > User > Extensions > ONE-vscode). This issue is related to in-house network restriction. To access the public ONE release page, we need to use GitHub Token in in-house enviornment. I fixed this issue with #1554.

The difficulty of using ONE toolchain has been talked about in #1553. If there is still a problem other than this issue, please share it.

#1598 (comment)

dayo09 commented

Notification type: modal vs balloon

The token is required only for the users from in-house network, so let's choose information balloon instead of warning modal.

dayo09 commented

Done :-D