[CFe] Fix ForwardTransposeOpPass with mixed 3D, 4D

Question

[CFe] Fix ForwardTransposeOpPass with mixed 3D, 4D

Closed this issue 3 months ago · 4 comments

There's a problem with mixed rank of 3 and 4 with ForwardTransposeOpPass

done

Answer 1 · 2024-06-18T01:01:01.000Z

This looks like Transpose should not go forward to Reshape as rank is different.
--> actually we should not forward Transpose with different I/O ranks.

Answer 2 · 2024-06-18T03:02:18.000Z

Could you explain a little bit more about mixed rank from the captured image?
I could't understand the image, because the input and output of the Transpose op have same rank 3 vs 3. (128x8x64 vs 8x128x64).
🥲

Answer 3 · 2024-06-18T03:16:27.000Z

Problem is Reshape, I:3D -> O:4D. If we move Transpose forward, Transpose has to be changed from 3D to 4D and it's perm too, which depends on reshape shape, which looks quite complicated.