Santandersecurityresearch/DrHeader

DrHeader exit with exit code 0 when detecting issues

Closed this issue · 2 comments

juan-medina commented
  • drHEADer version: 1.1.1
  • Python version: 3.6.9
  • Operating System: Linux Mint

DrHeader exit with exit code 0 when detecting issues, it should return a non zero code, then if execute via command-line tools we could use the exit code to understand if there were any errors.

$ drheader scan single https://santander.com
....

$ echo $?                              
0

When providing invalid arguments, or invalid URLs is already returning a non zero exit code.

$ drheader scan single https://owasp.com
Error: Failed to get headers.

$ echo $?                              
1
juan-medina commented

I've done a PR for this

pealtrufo commented

Thanks @juan-medina
Closing this issue as it is duplicated with #74