SasView/sasview

Clearing plots does not remove them from the Windows menu

Closed this issue · 3 comments

butlerpd commented

Describe the bug
closing/deleting plots (using the x button on the plot window) or clearing them from the window menu removes them from the plot from the GUI but not from the Window menu. Given issues #2837 it is not clear if this is just a manifestation of that issue or a separate issue.

To Reproduce
Steps to reproduce the behavior:

  1. Makes some fits (NOTE: that only subplots currently will allow a graph to show up in the Windows menu see issue #3017)
  2. Make some plots that include at least one subplot data set in each plot
  3. Delete some plots
  4. They still are in the menu
  5. Use the menu to clear all plots
  6. All the plots disappear but remain in the plot window

Expected behavior
Closing a plot using the x button should delete it from the SasView memory as that is the normal use of such a button. This should therefore also remove them from the Windows menu. My expectations would be that choosing to clear the plots from the Windows menu would also manifest by being removed from the menu in which case the plots should be deleted from memory.

The term "clear" is ambiguous. However I would argue that functionality wise if the desire is to get the plots out of the viewing window but retrievable that is already achieved by minimizing and having them available to be retrieved from the windows menu.

SasView version (please complete the following information):

  • Version: 6.0.0b2

Operating system (please complete the following information):

  • OS: Windows 10

Additional context
identified as part of the NIST CNR summer school and thus being labelled with 6.0.0 release tag. However it has not yet been checked to see if that is the also an issue in 5.0.6.

krzywon commented

This was introduced since 5.0.6. This must remain in 6.0.0

rozyczko commented

I am trying to reproduce the issue but can't.

  • loaded 2 datasets
  • sent to fitting
  • ran fitting on them with/without PD to get more plots

What I observe:

  • clicking X on a plot deletes its entry from both the Window menu and the "Append to" combobox
  • closing all plots (Window menu action) deletes them from both the canvas and the two locations above

Tested with https://github.com/SasView/sasview/releases/download/v6.0.0-beta-2/setupSasView-6.0.0-alpha-Win64.exe

krzywon commented

Tested a recent build and I agree with @rozyczko. This is now fixed.